Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka(ticdc): fix kafka dml sink report error to sink manager (#9879) #9894

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Oct 16, 2023

What problem does this PR solve?

Issue Number: ref #9855

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Oct 16, 2023
@hicqu hicqu removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Oct 16, 2023

It has already been merged into release-7.1: #9879.
And here is the cherry picking to release-6.5: #9880.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 16, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Oct 16, 2023

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 16, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 04:11:06.83795723 +0000 UTC m=+1630264.425067359: ☑️ agreed by 3AceShowHand.
  • 2023-10-16 04:17:23.130372461 +0000 UTC m=+1630640.717482604: ☑️ agreed by sdojjy.

@hicqu
Copy link
Contributor Author

hicqu commented Oct 16, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 0f4a8a1 into pingcap:master Oct 16, 2023
14 checks passed
@hicqu hicqu deleted the fix-kafka-sink-report-error branch October 16, 2023 05:09
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 7, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tiflow#release-7.1 from head ti-chi-bot:cherry-pick-9894-to-release-7.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.1 and ti-chi-bot:cherry-pick-9894-to-release-7.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants