Skip to content
This repository has been archived by the owner on Dec 28, 2017. It is now read-only.

Fix cast AIOB error #183

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Fix cast AIOB error #183

merged 2 commits into from
Dec 6, 2017

Conversation

Novemser
Copy link
Contributor

@Novemser Novemser commented Dec 6, 2017

Original row.set(row.fieldCount(), targetDataType, null); will surely cause AIOB error since row.fieldCount() number is out of bound.


This change is Reviewable

Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Novemser
Copy link
Contributor Author

Novemser commented Dec 6, 2017

Need add this to integration test case.

Like

select c1,cast(max(c2)as String) c2, max(c4) c4 from tb group by c1 limit 1

Need to add null data row.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants