Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support more json builtin function #105

Merged
merged 4 commits into from
Oct 12, 2018
Merged

support more json builtin function #105

merged 4 commits into from
Oct 12, 2018

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Sep 30, 2018 •
edited
Loading

pingcap/tidb#7546

json_keys
json_arrayagg
json_objectagg

@XuHuaiyu
Copy link
Contributor

LGTM

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Oct 8, 2018

Hi, @Kingwl
Did you install your tools fully refer to https://github.com/pingcap/tipb/blob/master/README.md ?

@Kingwl
Copy link
Contributor Author

Kingwl commented Oct 8, 2018 •
edited
Loading

@XuHuaiyu
sure , what wrong with that?😅

coocood
coocood previously requested changes Oct 8, 2018
View reviewed changes
proto/expression.proto Outdated
@@ -415,7 +416,8 @@ enum ScalarFuncSig {
JsonStorageSizeSig = 5021;
JsonDepthSig = 5022;
JsonKeysSig = 5023;
JsonLengthSig = 5024;
JsonKeys2ArgsSig = 5024;
JsonLengthSig = 5025;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change the code number, there will be a compatibility issue.

@Kingwl
Copy link
Contributor Author

Kingwl commented Oct 11, 2018

holy shit,
the name of aggfunc is json_arrayagg rather than json_arrayaggr😂

@Kingwl Kingwl mentioned this pull request Oct 12, 2018
Closed
zz-jason
zz-jason reviewed Oct 12, 2018
View reviewed changes
proto/expression.proto
@@ -416,6 +418,7 @@ enum ScalarFuncSig {
JsonDepthSig = 5022;
JsonKeysSig = 5023;
JsonLengthSig = 5024;
JsonKeys2ArgsSig = 5025;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this used for?

@zz-jason zz-jason dismissed coocood’s stale review October 12, 2018 11:24

comment already addressed

zz-jason
zz-jason approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 11e33c7 into pingcap:master Oct 12, 2018
@Kingwl Kingwl deleted the more_json branch October 12, 2018 15:49
@Kingwl Kingwl mentioned this pull request Oct 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@coocood coocood coocood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kingwl @XuHuaiyu @coocood @zz-jason