add join proto #171
Merged
add join proto #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced May 15, 2020
Closed
Signed-off-by: Fei Han <hanfei19910905@gmail.com> fix adjust join proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto add key range for table scan change go code
update protobuf-build to 0.11 and prost to 0.6 update ci image Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Signed-off-by: fredchenbj <cfworking@163.com>
SunRunAway
reviewed
Jun 17, 2020
Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
SunRunAway
reviewed
Jun 18, 2020
proto/executor.proto
Outdated
| } | ||
|
|
||
| message TableScan { | ||
| optional int64 table_id = 1 [(gogoproto.nullable) = false]; | ||
| repeated ColumnInfo columns = 2; | ||
| optional bool desc = 3 [(gogoproto.nullable) = false]; | ||
| repeated int64 primary_column_ids = 4; | ||
| optional EngineType next_read_engine = 5 [(gogoproto.nullable) = false]; // which engine we should in next step, only used by tiflash | ||
| repeated KeyRange ranges = 6 [(gogoproto.nullable) = false]; |
There was a problem hiding this comment.
Please document this field.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fei Han hanfei19910905@gmail.com