*: fix TLS cases #128
Merged
*: fix TLS cases #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
approved these changes
Nov 2, 2022
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
reviewed
Nov 2, 2022
| @@ -124,7 +126,12 @@ func (ci *certInfo) customizeTLSConfig(tlsConfig *tls.Config) *tls.Config { | |||
| } | |||
| } else { | |||
| tlsConfig.GetClientCertificate = func(*tls.CertificateRequestInfo) (*tls.Certificate, error) { | |||
| return ci.getCertificate(), nil | |||
| cert := ci.getCertificate() | |||
There was a problem hiding this comment.
Why not return the emptyCert in the getCertificate? It will also work when ci.isServer==true.
There was a problem hiding this comment.
GetCertificate and GetClientCertificate has different requirements. I mean GetCertificate should return nil. Moreover, on server-side tls config, it is promised to be nil if certs are nil.
| @@ -124,7 +126,12 @@ func (ci *certInfo) customizeTLSConfig(tlsConfig *tls.Config) *tls.Config { | |||
| } | |||
| } else { | |||
| tlsConfig.GetClientCertificate = func(*tls.CertificateRequestInfo) (*tls.Certificate, error) { | |||
| return ci.getCertificate(), nil | |||
| cert := ci.getCertificate() | |||
| if cert == nil { | |||
There was a problem hiding this comment.
When is cert == nil? If the tlsConfig is nil, it won't come here. If the tlsConfig is not nil, can cert be nil?
There was a problem hiding this comment.
A tls config with only CA, or even without CA insecureSkipVerify. This is client only behavior.
xhebox
added a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 7, 2023
xhebox
added a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Issue Number: close None
Problem Summary: If server enables TLS, but we don't have certs to complete TLS handshake, there is a panic.
What is changed and how it works:
backendTLSConfigGetClientCertificateCheck List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.