Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: tls refactor #146

Merged
merged 5 commits into from
Dec 15, 2022
Merged

*: tls refactor #146

merged 5 commits into from
Dec 15, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Dec 7, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: ref #136

Problem Summary: proxy.NewSQLServer still relies heavily on certManager. This is a preparation for the later PR.

CertManager is largely simplified by moving reloading functions into certInfo, which is moved to /lib package. I expect that:

  1. proxy.NewSQLServer could workaround certManager by interfaces hack
  2. per-namespace TLS will replace certManager eventually

Some minor but function-neutral changes are done to the certInfo. And AutoTLS is replaced by CreateTempTLS, i.e. auto tls rotation is now done in memory completely.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 December 7, 2022 04:42
@xhebox xhebox mentioned this pull request Dec 7, 2022
13 tasks
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit 5490197 into pingcap:main Dec 15, 2022
@xhebox xhebox mentioned this pull request Dec 27, 2022
8 tasks
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants