Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add /api/debug/health #193

Merged
merged 4 commits into from
Jan 17, 2023
Merged

api: add /api/debug/health #193

merged 4 commits into from
Jan 17, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 12, 2023

What problem does this PR solve?

Issue Number: ref #161

Problem Summary: Depends on #191 , a better API for health checking. Also fixes for dockerfile. Also add tiproxyctl health.

Well-tested with the new tidb-operator PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox xhebox requested a review from djshow832 January 12, 2023 14:17
@xhebox xhebox force-pushed the dedicate_7 branch 2 times, most recently from 682703f to 25d4445 Compare January 12, 2023 15:35
@djshow832
Copy link
Collaborator

Please fix conflicts first

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Copy link
Collaborator Author

xhebox commented Jan 17, 2023

Please fix conflicts first

Done

Signed-off-by: xhe <xw897002528@gmail.com>
Copy link
Collaborator

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

lib/cli/health.go Outdated Show resolved Hide resolved
@djshow832
Copy link
Collaborator

I didn't see any unit tests, please remove the Unit Test checkbox in the PR description.

Co-authored-by: djshow832 <zhangming@pingcap.com>
@djshow832 djshow832 merged commit f2a197c into pingcap:main Jan 17, 2023
@xhebox xhebox deleted the dedicate_7 branch March 7, 2023 03:18
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants