Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config, api: add API for getting the config checksum #203

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Jan 31, 2023

What problem does this PR solve?

Issue Number: close #202

Problem Summary:
The operator or some other tools can fetch the checksum to know the version of the config.

What is changed and how it works:
Add the get checksum API for ConfigManager and HTTP.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox January 31, 2023 07:28
pkg/manager/config/config.go Outdated Show resolved Hide resolved
pkg/manager/config/manager.go Outdated Show resolved Hide resolved
@djshow832 djshow832 requested a review from xhebox January 31, 2023 13:53
@xhebox xhebox merged commit df06ec4 into pingcap:main Feb 1, 2023
@djshow832 djshow832 deleted the checksum branch February 1, 2023 06:20
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide API to get the checksum of the config
2 participants