Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config, router: add health check switch #206

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Feb 1, 2023

What problem does this PR solve?

Issue Number: close #205

Problem Summary:
The serverless tier doesn't need health check, because the standby tidb might be unhealthy.

What is changed and how it works:

  • Add a member Enable to config.HealthCheck.
  • Move router.HealthCheckConfig to config.HealthCheck and rename some members.
  • Add a parameter *config.HealthCheck to NewScoreBasedRouter().

TODO:

  • Add config.HealthCheck to the configuration file. Currently, it's still using the default value.
  • The config.HealthCheck parameter of ScoreBasedRouter and PDFetcher is duplicated and should be refined.
  • Unit tests

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox February 1, 2023 14:00
@xhebox xhebox merged commit 4a70be3 into pingcap:main Feb 1, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
@djshow832 djshow832 deleted the health branch September 2, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a switch for health check
2 participants