Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: add basic UT for config manager #21

Merged
merged 6 commits into from
Jul 29, 2022
Merged

manager: add basic UT for config manager #21

merged 6 commits into from
Jul 29, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jul 29, 2022

What problem does this PR solve?

Issue Number: ref #11

Problem Summary: Prepare for testing namespace manager.

What is changed and how it works:

  1. Removed getMul since it is overdesigned.
  2. The returned value of del is removed.
  3. Added a basic UT for config manager

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 July 29, 2022 03:29
Signed-off-by: xhe <xw897002528@gmail.com>
pkg/manager/config/manager_test.go Outdated Show resolved Hide resolved
pkg/manager/config/manager_test.go Outdated Show resolved Hide resolved
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 July 29, 2022 08:15
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit 7edc004 into pingcap:main Jul 29, 2022
@xhebox xhebox deleted the namespace_2 branch July 29, 2022 09:04
@xhebox xhebox mentioned this pull request Aug 3, 2022
2 tasks
@xhebox xhebox mentioned this pull request Jul 29, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants