Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: fix server side verification #221

Merged
merged 2 commits into from
Feb 22, 2023
Merged

tls: fix server side verification #221

merged 2 commits into from
Feb 22, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Feb 15, 2023

What problem does this PR solve?

Issue Number: close #220

Problem Summary: Due to wrong ClientAuth, it is not working as expected. With VerifyClientCertIfGiven, the verify function from golang will be invoked using empty CA list, resulting into some errors.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit a55e6b6 into pingcap:main Feb 22, 2023
@xhebox xhebox deleted the tls_1 branch February 23, 2023 02:54
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server side verification not working
2 participants