Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: add ssl to packet for HandshakeHandler #226

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close None

Problem Summary:
Some drivers don't set ClientSSL in the second packet, but the HandshakeHandler wants the real capability.

What is changed and how it works:
Use the first capability for HandshakeHandler.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox March 1, 2023 06:42
@xhebox xhebox merged commit 61c436c into pingcap:main Mar 1, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
@djshow832 djshow832 deleted the add_ssl branch September 2, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants