Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: complete some definitions #250

Merged
merged 2 commits into from
Mar 22, 2023
Merged

net: complete some definitions #250

merged 2 commits into from
Mar 22, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Mar 13, 2023

What problem does this PR solve?

Issue Number: ref #248

Problem Summary: The current backend must convert from *PacketIO oriented to []byte/MysqlPacket oriented. Command processor or authenticator should not read from the connection actively. To do this, we should provide a set of helpers that deals with packets, instead of *PacketIO.

What is changed and how it works:

  1. This packet completes mysql.ComXXX definition. The next one will provide more helpers.
  2. fix post merge CI.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 March 13, 2023 09:54
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit 45df1bc into pingcap:main Mar 22, 2023
@xhebox xhebox deleted the r4 branch March 22, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants