Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: fix proxy protocol #274

Merged
merged 2 commits into from
May 5, 2023
Merged

net: fix proxy protocol #274

merged 2 commits into from
May 5, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Apr 25, 2023

What problem does this PR solve?

Issue Number: close #273

Problem Summary: tiproxy did not try to parse PP headers. PP is disabled by default during introducing serverless support. Since then it is always disabled, and never get fixed.

What is changed and how it works:

  1. WithProxy should set proxyInited = false.
  2. Add unit tests to prevent regression.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 April 25, 2023 06:42
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit d0e6292 into main May 5, 2023
@djshow832 djshow832 deleted the fix_1 branch May 5, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxyprotocol not working
2 participants