Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix metrics Get Backend Count and Ping Backend Duration #280

Merged
merged 1 commit into from
May 16, 2023

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #279

Problem Summary:

  • Get Backend Count shows 2 succeed without instance names
  • Ping Backend Duration shows double legends, one is 2s and one is a normal value

What is changed and how it works:

  • Add instance name to Get Backend Count
  • Remove res label from Ping Backend Duration

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

screenshot-20230515-220511

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox May 15, 2023 14:06
@djshow832 djshow832 merged commit 8bbb0e9 into pingcap:main May 16, 2023
@djshow832 djshow832 deleted the fix_metrics branch May 16, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics of Ping Backend Duration has double legends
2 participants