Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: log every change #290

Merged
merged 4 commits into from
May 26, 2023
Merged

config: log every change #290

merged 4 commits into from
May 26, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented May 23, 2023

What problem does this PR solve?

Issue Number: ref #286

Problem Summary: Print config every update

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox
config: log it every change
67c2bf8 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 May 23, 2023 09:32
@xhebox xhebox changed the title config: log it every change config: log every change May 23, 2023
@xhebox
fix test
d871ee8 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
comments
81c80fc 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Merge branch 'main' into ecs_3
886a9ea
@djshow832 djshow832 merged commit db9c99f into pingcap:main May 26, 2023
@xhebox xhebox deleted the ecs_3 branch May 26, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhebox @djshow832