backend: refine the error message when require TLS #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #312
Problem Summary:
When the TiDB disables TLS and TiProxy enables require-backend-tls, the client receives error
(1105, 'Verify TiDB capability failed, please upgrade TiDB')
. This makes users confused when users deploy the TiDB cluster by themselves. We should tell them that TiDB should enable TLS.What is changed and how it works:
Check List
Tests
require-backend-tls = true
ERROR 1105 (HY000): Require TLS config on TiDB when require-backend-tls=true
. In the log:[new connection failed] [connID=0] [client_addr=127.0.0.1:53490] [proxy-protocol=false] [backend_addr=127.0.0.1:4000] ["quit source"="proxy error"] [error="backend doesn't enable TLS"]
security.sql-tls.skip-ca = false
.ERROR 1105 (HY000): Require TLS config on TiProxy when require-backend-tls=true
. In the log:[new connection failed] [connID=0] [client_addr=127.0.0.1:55840] [proxy-protocol=false] [backend_addr=127.0.0.1:4000] ["quit source"="proxy error"] [error="tiproxy doesn't enable TLS"]
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.