Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add json format response #385

Merged
merged 1 commit into from
Oct 19, 2023
Merged

api: add json format response #385

merged 1 commit into from
Oct 19, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Oct 19, 2023

What problem does this PR solve?

Issue Number: close #384

Problem Summary: as title

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

add ?format= query parameter for /api/admin/config

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 October 19, 2023 05:30
@ti-chi-bot ti-chi-bot bot added the size/XS label Oct 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-19 06:30:40.943356311 +0000 UTC m=+1897838.530466453: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 19, 2023
@djshow832 djshow832 merged commit 3354c7a into pingcap:main Oct 19, 2023
9 checks passed
@xhebox xhebox mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

for config api
2 participants