Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: get unicast ip only when the config one is not #386

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Oct 19, 2023

What problem does this PR solve?

Issue Number: close #383

Problem Summary: when tiproxy listens on 127.0.0.1:2379, it also tries to report another unicast IP, e.g. 192.168.4.43. This does not make sense.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 October 19, 2023 08:31
@ti-chi-bot ti-chi-bot bot requested a review from bb7133 October 19, 2023 08:31
@ti-chi-bot ti-chi-bot bot added the size/S label Oct 19, 2023
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Oct 19, 2023
@xhebox xhebox requested a review from djshow832 October 19, 2023 10:01
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 06:18:14.878331201 +0000 UTC m=+1983492.465441349: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit 28d53d3 into pingcap:main Oct 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add cluster_info to tidb
2 participants