Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add grpc and diagnostics #388

Merged
merged 6 commits into from
Nov 2, 2023
Merged

api: add grpc and diagnostics #388

merged 6 commits into from
Nov 2, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Oct 25, 2023

Issue Number: ref #387

Problem Summary: GRPC service is implemented by github.com/pingcap/sysutil. So this PR is trvial. Main changes are in pkg/server/api/http.go.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support diagnosticspb grpc service for cluster_xxx system tables

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 October 25, 2023 06:53
@ti-chi-bot ti-chi-bot bot added the size/XL label Oct 25, 2023
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Copy link
Collaborator Author

xhebox commented Oct 25, 2023

/retest

Copy link
Collaborator

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests? The test coverage of this pkg is still 0.

pkg/server/api/http.go Show resolved Hide resolved
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/XL labels Nov 1, 2023
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 November 1, 2023 07:53
@djshow832
Copy link
Collaborator

Fix CI

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Copy link
Collaborator Author

xhebox commented Nov 2, 2023

Fix CI

Done

Copy link

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 2, 2023
Copy link

ti-chi-bot bot commented Nov 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-02 06:10:46.335283245 +0000 UTC m=+3106243.922393391: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8d0bf38 into pingcap:main Nov 2, 2023
9 checks passed
@xhebox xhebox mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants