-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add grpc and diagnostics #388
Conversation
Signed-off-by: xhe <xw897002528@gmail.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests? The test coverage of this pkg is still 0.
Signed-off-by: xhe <xw897002528@gmail.com>
Fix CI |
Done |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djshow832 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Issue Number: ref #387
Problem Summary: GRPC service is implemented by
github.com/pingcap/sysutil
. So this PR is trvial. Main changes are inpkg/server/api/http.go
.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.