backend, net: optimize read/write connection by forwarding packets #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #381
Problem Summary:
The performance is still not good enough. We can just forward the packets between connections and avoid allocating memory and copying data.
What is changed and how it works:
PacketIO.ForwardUntil
and call it inCmdProcessor.forwardUntilResultEnd
.ForwardUntil
only allocates memory in the last packet.ForwardUntil
mainly callsWriter.ReadFrom
to copy data between reader and writer.bufio.go
to TiProxy becauseWriter.ReadFrom
always callsTCPConn.ReadFrom
, which calls sys calls and skips the buffer. We always need the buffer and I can't find a replacement ofbufio
.ReadFrom
for all thepacketReadWriter
implementations.IsXXXPacket
because we only know the length and first byte if we do the optimization.compressedReadWriter.Peek
to avoid allocating memory.proxyReadWriter.Peek
. It was a bug not to add this function.Check List
Tests
Sysbench Result
Before this PR (with
conn-buffer-size=131072
):After this PR (with
conn-buffer-size=131072
):Flame Graph
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.