-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend, net: reduce memory allocation in forwarding packets #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djshow832
changed the title
backend, net: Use more
backend, net: reduce memory allocation in forwarding packets
Nov 2, 2023
ForwardUntil
to reduce memory allocation
/retest |
xhebox
approved these changes
Nov 6, 2023
xhebox
approved these changes
Nov 6, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #381
Problem Summary:
ForwardUntil
for more kinds of packets, such as the OK packet.What is changed and how it works:
ForwardUntil
inforwardPrepareCmd
,forwardQueryCmd
, andforwardResultSet
.ForwardUntil
.handleOKPacket
and ignore other fields.load local infile
because we have a fixed buffer anyway.Check List
Tests
Performance tests:
BenchmarkForwardUntil
is close toBenchmarkForwardWithReadWrite
whenloops<=10
but it becomes much better whenloops>100
.Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.