Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend, net: log client versions #395

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #369

Problem Summary:
Some client versions are in the connection attributes. If we can log them once the connection is created, it might be helpful for troubleshooting.

What is changed and how it works:

  • Move the log connected to backend after the connection is established.
  • Add client names and versions in the log.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
[2023/11/08 16:25:28.157 +08:00] [INFO] [main.proxy.conn] [client/client_conn.go:52] [connected to backend] [connID=5] [client_addr=127.0.0.1:65006] [addr=0.0.0.0:6000] [client_version=8.1.0] [client_name=libmysql] [capability=CLIENT_LONG_PASSWORD|CLIENT_LONG_FLAG|CLIENT_CONNECT_WITH_DB|CLIENT_LOCAL_FILES|CLIENT_PROTOCOL_41|CLIENT_SSL|CLIENT_TRANSACTIONS|CLIENT_SECURE_CONNECTION|CLIENT_MULTI_STATEMENTS|CLIENT_MULTI_RESULTS|CLIENT_PLUGIN_AUTH|CLIENT_CONNECT_ATTS|CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA|CLIENT_DEPRECATE_EOF] [proxy-protocol=false] [backend_addr=127.0.0.1:4000]

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox November 8, 2023 09:29
@ti-chi-bot ti-chi-bot bot added the size/M label Nov 8, 2023
Copy link

ti-chi-bot bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-08 09:52:30.548804007 +0000 UTC m=+3637948.135914136: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit d394ee5 into pingcap:main Nov 8, 2023
8 of 9 checks passed
@djshow832 djshow832 deleted the conn_attr branch November 9, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log the client versions
2 participants