Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support online reload for some config #396

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #94

Problem Summary:

  • Some configurations can not be reloaded dynamically
  • Some configurations may not be used. This will be a burden after GA.

What is changed and how it works:

  • Remove selector-type because it's useless
  • Make require-backend-tls able to be hot reloaded
  • Remove server-version: the router reads the TiDB version and doesn't need a configured one
  • Remove api.user, password, and enable-basic-auth: TiDB doesn't have these configs
  • Make metrics able to be hot reloaded

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox November 10, 2023 03:45
@ti-chi-bot ti-chi-bot bot added the size/L label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 10, 2023
Copy link

ti-chi-bot bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-10 03:49:00.674815712 +0000 UTC m=+3788938.261925856: ☑️ agreed by xhebox.
  • 2023-11-10 06:18:25.997575909 +0000 UTC m=+3797903.584686054: ✖️🔁 reset by djshow832.
  • 2023-11-10 07:08:11.069221163 +0000 UTC m=+3800888.656331308: ☑️ agreed by xhebox.

@djshow832
Copy link
Collaborator Author

/retest

1 similar comment
@djshow832
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 39626dd into pingcap:main Nov 10, 2023
9 checks passed
@djshow832 djshow832 deleted the router_config branch November 10, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically update more configurations
2 participants