backend: add tests for BackendConnMgr #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhebox
reviewed
Aug 19, 2022
Comment on lines
+112
to
+114
| conn, err := ts.tc.backendListener.Accept() | ||
| require.NoError(ts.t, err) | ||
| ts.tc.backendIO = pnet.NewPacketIO(conn) |
There was a problem hiding this comment.
We don't really need to bypass this by WithBackend. All test cases will accept the handshake.
Only TestRedirectFail is re-accepting the conenction after the first handshake. So maybe wrap this pattern in to a method ts.BackendAccept().
xhebox
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #40
Problem Summary:
Add tests for
BackendConnMgr.What is changed and how it works:
Add unit tests and update some comments.
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.