Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: move require-backend-tls from proxy to security #419

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Dec 22, 2023

What problem does this PR solve?

Issue Number: close #411

Problem Summary:

  • require-backend-tls is more like a security config
  • require-backend-tls is true by default, which causes some compatible problems when updating it

What is changed and how it works:

  • Move require-backend-tls from proxy section to security
  • Change the default value of require-backend-tls to false

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
tiup playground v7.5.0 --tiproxy 1 --tiproxy.binpath /Users/zhangming/gopath/src/github.com/pingcap/tiproxy/bin/tiproxy --tiproxy.config cfg --tiflash 0

cat cfg
[proxy]
  require-backend-tls = false

This proves that it's compatible with the previous config.

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox December 22, 2023 08:56
@ti-chi-bot ti-chi-bot bot added the size/M label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot added size/L and removed size/M labels Dec 22, 2023
@djshow832
Copy link
Collaborator Author

/retest

Copy link

ti-chi-bot bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 22, 2023
Copy link

ti-chi-bot bot commented Dec 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 09:36:54.869577937 +0000 UTC m=+1212905.906804863: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit b1d210f into pingcap:main Dec 22, 2023
5 checks passed
@djshow832 djshow832 deleted the require_tls branch December 22, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move require-backend-tls from proxy to security
2 participants