config: fix url config #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xhe <xw897002528@gmail.com>
xhebox
commented
Aug 18, 2022
Comment on lines
+75
to
+80
| var wg waitgroup.WaitGroup | ||
| wg.Run(func() { | ||
| if err := srv.Run(cmd.Context()); err != nil { | ||
| logger.Error("shutdown with error", zap.Error(err)) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Since Run(the listener) is blocking, we must run it in a separate go routine.
djshow832
reviewed
Aug 18, 2022
| - "0.0.0.0:2379" | ||
| - "http://0.0.0.0:3080" | ||
| advertise-urls: | ||
| - "http://127.0.0.1:3080" |
There was a problem hiding this comment.
Why some of them are 0.0.0.0 while others 127.0.0.1?
There was a problem hiding this comment.
advertise-xxx is used by etcd server to tell other etcd servers what address they should use to connect. 0.0.0.0 is correct for Listen() but wrong for Dial(). We could change both to 127.0.0.1.
listen/advertise-urls are used for etcd client. xxx-peer-urls are for inter-etcd-servers communication.
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Issue Number: ref #23
Problem Summary: Fix logic of handling
urls.What is changed and how it works:
config/weirproxy.yaml.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.