Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MinTLSVersion to TLSv1.2 #437

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Dec 29, 2023

What problem does this PR solve?

Issue Number: ref pingcap/tidb#36036

Problem Summary:

IETF RFC 8996 says TLSv1.1 and older should not be used by default.

What is changed and how it works:

This changes the minimum TLS version to TLSv1.2.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The minimum TLS version was changed to TLSv1.2. This can be changed in the configuration file.

Warning

This change should be clearly listed in release notes etc as depending on the MySQL driver and connection configuration this might lead to problems.

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 December 29, 2023 10:36
@ti-chi-bot ti-chi-bot bot added the size/XS label Dec 29, 2023
@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Dec 29, 2023
@djshow832
Copy link
Collaborator

I heard that pingcap/tidb#36037 is under discussion. I'll merge this PR after the TiDB PR is merged because TiProxy needs to be consistent with TiDB.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 5, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 5, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 08:20:43.590802707 +0000 UTC m=+2417934.628029635: ☑️ agreed by djshow832.
  • 2024-01-05 08:29:19.767912438 +0000 UTC m=+2418450.805139366: ✖️🔁 reset by djshow832.
  • 2024-01-05 08:29:44.708863444 +0000 UTC m=+2418475.746090371: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot merged commit 8191da9 into pingcap:main Jan 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants