Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: print welcom after config init #454

Merged
merged 3 commits into from
Jan 18, 2024
Merged

log: print welcom after config init #454

merged 3 commits into from
Jan 18, 2024

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 17, 2024

What problem does this PR solve?

Issue Number: close #453

Problem Summary: The root cause that tiup-cluster did not print the welcome log is that, tiproxy prints the message to stdout, which goes to system units.

And it is basically impossible/very hard to redirect that to the log file on tiup-cluster. Instead, we just print the log after config initialization,

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 January 17, 2024 08:41
@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 17, 2024
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 18, 2024
Copy link

ti-chi-bot bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-18 06:20:19.185226235 +0000 UTC m=+423260.749523937: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit f13c08f into pingcap:main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome log is not printed in tiup cluster
2 participants