Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Certificate-Based Authentication #479

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #464

Problem Summary:
This proposes a design of supporting certificate-based authentication on TiProxy.

What is changed and how it works:
Add a RFC.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from djshow832, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox March 4, 2024 10:55
@ti-chi-bot ti-chi-bot bot added the size/M label Mar 4, 2024
@ti-chi-bot ti-chi-bot bot added size/L and removed size/M labels Mar 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@1c32cf8). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage        ?   64.43%           
=======================================
  Files           ?       61           
  Lines           ?     5809           
  Branches        ?        0           
=======================================
  Hits            ?     3743           
  Misses          ?     1779           
  Partials        ?      287           
Flag Coverage Δ
unit 64.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants