Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: deprecate cmd args log_level and log_encoder #504

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #449

Problem Summary:
log_level and log_encoder conflict with the configs which support hot reload. This may confuse users when they update the config file.

What is changed and how it works:
Deprecate log_level and log_encoder. They will be removed in the future.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
$ bin/tiproxy --help
start the proxy server

Usage:
  bin/tiproxy [flags]

Flags:
      --advertise-addr string   advertise address
      --config string           proxy config file path
  -h, --help                    help for bin/tiproxy
      --log_encoder string      deprecated and will be removed
      --log_level string        deprecated and will be removed
  -v, --version                 version for bin/tiproxy


$ bin/tiproxy --log_level=debug
// started normally

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Deprecate the command line arguments `log_level` and `log_encoder`

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox April 12, 2024 01:56
@ti-chi-bot ti-chi-bot bot added the size/XS label Apr 12, 2024
Copy link

ti-chi-bot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 12, 2024
Copy link

ti-chi-bot bot commented Apr 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 01:57:22.155316609 +0000 UTC m=+1186703.682857154: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 61c6085 into pingcap:main Apr 12, 2024
4 of 5 checks passed
@djshow832 djshow832 deleted the deprecate_args branch April 20, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants