Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: support CLIENT_DEPRECATE_EOF #52

Merged
merged 4 commits into from
Aug 24, 2022
Merged

backend: support CLIENT_DEPRECATE_EOF #52

merged 4 commits into from
Aug 24, 2022

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Aug 23, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #45

Problem Summary:
TiDB now supports CLIENT_DEPRECATE_EOF, so the proxy needs to support CLIENT_DEPRECATE_EOF.

What is changed and how it works:

  • Support CLIENT_DEPRECATE_EOF for CmdProcessor and testSuite.
  • Update the capability for the authenticator when executing CMD_SET_OPTION.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Tested with:

  • MySQL client with simple statements
  • sysbench: oltp_point_select
  • JDBC: test streaming read using fetch size

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox August 23, 2022 08:03
xhebox
xhebox reviewed Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe needs some cleanup later, but there is no essential problem to me.

pkg/proxy/backend/backend_conn_mgr.go Show resolved Hide resolved
pkg/proxy/backend/cmd_processor_exec.go Outdated Show resolved Hide resolved
@xhebox xhebox merged commit 64e87f0 into pingcap:main Aug 24, 2022
@djshow832 djshow832 deleted the deprecate_eof branch August 24, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support CLIENT_DEPRECATE_EOF capability
2 participants
@djshow832 @xhebox