Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: use json for API and internal storage #66

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Aug 31, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: ref #11

Problem Summary: Reduce assumption on what format the server will return or store.

What is changed and how it works: The server will process json only now. The cli is resposible to convert it from yaml to json or vice versa.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
./bin/weirctl namespace list
./bin/weirctl namespace get default
./bin/weirctl namespace put
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox mentioned this pull request Aug 31, 2022
5 tasks
@xhebox xhebox requested a review from djshow832 August 31, 2022 03:39
@djshow832 djshow832 merged commit 12c633b into pingcap:main Aug 31, 2022
@xhebox xhebox deleted the config_4 branch August 31, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants