backend: fix the bug that the redirection signal may be discarded #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close None
Problem Summary:
Some test cases are unstable, such as
TestNormalRedirect
(https://github.com/pingcap/TiProxy/runs/8181135325?check_suite_focus=true) andTestRedirectFail
.Reason:
This is a bug introduced by #72. It doesn't only happen in testing.
Since
BackendConnManager.processSignals
also handlesmgr.redirectResCh
now, this may happen:notifyRedirectResult()
and callsOnRedirectSucceed()
.notifyRedirectResult()
but does not go to theselect-case
yet.BackendConnManager.Redirect
is a non-blocking function but the size of channelsignalReceived
is 0, it discards the signal because it needs to wait.What is changed and how it works:
Actually, doing one of these modifications is enough, but I modified them both to be more secure:
signalReceived
to 1.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.