Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: fix unstable test TestConnBalanced #82

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close None

Problem Summary:
TestConnBalanced is unstable because I forgot to call redirectFinish before checking metrics.

What is changed and how it works:
Add redirectFinish. I tested it several times and it's OK now.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox xhebox merged commit 5461943 into pingcap:main Sep 13, 2022
@djshow832 djshow832 deleted the fix_conn_test branch September 14, 2022 02:19
@xhebox xhebox mentioned this pull request Sep 15, 2022
3 tasks
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants