*: add lint CI #99
Merged
*: add lint CI #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
reviewed
Sep 27, 2022
| // The original db in the auth info may be dropped during the session, so we need to authenticate with the current db. | ||
| // The user may be renamed during the session, but the session cannot detect it, so this will affect the user. | ||
| // TODO: this may be a security problem: a different new user may just be renamed to this user name. | ||
| func (mgr *BackendConnManager) updateAuthInfoFromSessionStates(sessionStates []byte) error { |
There was a problem hiding this comment.
It's a mistake that it's not used. It should be called, or the default db should be set to "" in the second handshake.
There was a problem hiding this comment.
Would you mind fixing it in another PR? Then I don't need to write related tests.
There was a problem hiding this comment.
Sure. Please revert this function. I will do it after the proxy protocol PR is merged.
There was a problem hiding this comment.
Done, /cc @djshow832
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
approved these changes
Sep 28, 2022
8 tasks
xhebox
added a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 7, 2023
xhebox
added a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Issue Number: close None
Problem Summary: As title.
What is changed and how it works: Notables:
updateAuthInfoFromSessionStatesis removed/unused.BuildLoggeris moved to./lib.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.