Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index related integration tests #139

Merged
merged 14 commits into from
Dec 21, 2017
Merged

Add index related integration tests #139

merged 14 commits into from
Dec 21, 2017

Conversation

birdstorm
Copy link
Contributor

for #129

@ilovesoup
Copy link
Contributor

What does this fix really do?

@birdstorm
Copy link
Contributor Author

This pr adds index tests on all data types. Testing, not pushed yet.

@birdstorm
Copy link
Contributor Author

birdstorm commented Dec 20, 2017 •
edited
Loading

when executing ./test_no_tpch.sh which runs custom tests and index tests:

Result: Tests run: 1220 Tests succeeded: 725 Tests failed: 193 Tests skipped: 302

PTAL @ilovesoup

@birdstorm
Copy link
Contributor Author

birdstorm commented Dec 20, 2017 •
edited
Loading

when executing ./test_dag.sh which runs dag tests:

Result: Tests run: 7311 Tests succeeded: 3749 Tests failed: 8 Tests skipped: 3554

Novemser
Novemser approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@Novemser Novemser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as conflicts are resolved.

@birdstorm birdstorm merged commit 62bcd7f into master Dec 21, 2017
@birdstorm birdstorm deleted the add_index_tests branch December 21, 2017 12:08
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@birdstorm
Add index related integration tests (pingcap#139)
8eb0c53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Novemser Novemser Novemser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birdstorm @ilovesoup @Novemser