Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test framework for each issue #141

Merged
merged 3 commits into from
Dec 19, 2017
Merged

Add test framework for each issue #141

merged 3 commits into from
Dec 19, 2017

Conversation

birdstorm
Copy link
Contributor

A test framework consisting of integration tests for each fixed issue so that we can locate the problem faster when refactoring.

Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

*
* @param dbName Name of database, the default is issue_test
*/
private def TestClient0198(dbName: String): Unit = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does 0198 means?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as described in comment above

@ilovesoup ilovesoup merged commit c65a12e into master Dec 19, 2017
@birdstorm birdstorm deleted the addIssueTests branch December 19, 2017 09:04
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants