Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test cases. #233

Merged
merged 9 commits into from
Feb 28, 2018
Merged

Add more test cases. #233

merged 9 commits into from
Feb 28, 2018

Conversation

Novemser
Copy link
Contributor

@Novemser Novemser commented Feb 5, 2018 •
edited
Loading

The following tests were added:

  1. Issue tests.
  2. Expression in aggregate functions.
  3. Expression in group by functions.
  4. Logical and or test.

Known potential issue fix:

  1. Replace some count(1) with id_dt

@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@Novemser
Copy link
Contributor Author

Novemser commented Feb 5, 2018

/ok-to-test

@Novemser
Copy link
Contributor Author

Novemser commented Feb 5, 2018

/run-all-tests

@birdstorm
Copy link
Contributor

/run-all-tests tikv=pr/2738

@Novemser
Copy link
Contributor Author

/run-all-tests

@Novemser
Copy link
Contributor Author

/run-all-tests

@Novemser
Copy link
Contributor Author

/run-all-tests

@Novemser
Copy link
Contributor Author

@birdstorm @ilovesoup PTAL

@Novemser
Copy link
Contributor Author

/run-all-tests

1 similar comment
@Novemser
Copy link
Contributor Author

/run-all-tests

@Novemser Novemser merged commit f6dc33a into master Feb 28, 2018
@Novemser Novemser deleted the add_issue_tests branch February 28, 2018 04:55
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@Novemser
Add more test cases. (pingcap#233)
d64b313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Novemser @sre-bot @birdstorm