Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TISPARK-36] Improve test logic #344

Merged
merged 3 commits into from
May 14, 2018
Merged

[TISPARK-36] Improve test logic #344

merged 3 commits into from
May 14, 2018

Conversation

birdstorm
Copy link
Contributor

@birdstorm birdstorm commented May 4, 2018

TestSuite cannot handle tests with limit but without orderBy, e.g., select * from t limit 20.

If sql contains limit but not orderBy, the test result should be undefined.

@birdstorm
Copy link
Contributor Author

/run-all-tests

@birdstorm birdstorm changed the title Improve test logic [TISPARK-36] Improve test logic May 4, 2018
@birdstorm birdstorm requested a review from Novemser May 4, 2018 15:15
@birdstorm
Copy link
Contributor Author

birdstorm commented May 4, 2018

PTAL @Novemser thx~

@birdstorm
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@Novemser Novemser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Novemser
Copy link
Contributor

/run-all-tests

@Novemser
Copy link
Contributor

Novemser commented May 13, 2018

@birdstorm PTAL to these failed cases before merge. Seems related to statistics information.

@birdstorm
Copy link
Contributor Author

/run-all-tests

@Novemser Novemser merged commit ed2e18e into master May 14, 2018
@Novemser Novemser deleted the improve_test_logic branch May 14, 2018 10:18
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants