cluster: set owner to current user when decompressing tarballs (#713)

pingcap · Aug 26, 2020 · 104839b · 104839b
1 parent 91c5f94
commit 104839b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/components/dm/spec/grafana.go b/components/dm/spec/grafana.go
@@ -187,7 +187,7 @@ func (i *GrafanaInstance) Deploy(t *task.Builder, srcPath string, deployDir stri
 			return errors.AddStack(err)
 		}
 
-		cmd := fmt.Sprintf(`tar -xzf %s -C %s && rm %s`, dstPath, tmp, dstPath)
+		cmd := fmt.Sprintf(`tar --no-same-owner -zxf %s -C %s && rm %s`, dstPath, tmp, dstPath)
 		_, stderr, err = e.Execute(cmd, false)
 		if err != nil {
 			return errors.Annotatef(err, "stderr: %s", string(stderr))

diff --git a/components/dm/spec/prometheus.go b/components/dm/spec/prometheus.go
@@ -165,7 +165,7 @@ func (i *MonitorInstance) Deploy(t *task.Builder, srcPath string, deployDir stri
 			return errors.AddStack(err)
 		}
 
-		cmd := fmt.Sprintf(`tar -xzf %s -C %s && rm %s`, dstPath, tmp, dstPath)
+		cmd := fmt.Sprintf(`tar --no-same-owner -zxf %s -C %s && rm %s`, dstPath, tmp, dstPath)
 		_, stderr, err = e.Execute(cmd, false)
 		if err != nil {
 			return errors.Annotatef(err, "stderr: %s", string(stderr))

diff --git a/pkg/cluster/operation/telemetry.go b/pkg/cluster/operation/telemetry.go
@@ -89,7 +89,7 @@ func GetNodeInfo(
 			}
 
 			// get node info by exec _telemetry node_info at remote instance.
-			cmd := fmt.Sprintf(`tar -xzf %s -C %s && rm %s`, dstPath, dstDir, dstPath)
+			cmd := fmt.Sprintf(`tar --no-same-owner -zxf %s -C %s && rm %s`, dstPath, dstDir, dstPath)
 			_, stderr, err := exec.Execute(cmd, false)
 			if err != nil {
 				return errors.Annotatef(err, "stderr: %s", string(stderr))

diff --git a/pkg/cluster/task/install_package.go b/pkg/cluster/task/install_package.go
@@ -45,7 +45,7 @@ func (c *InstallPackage) Execute(ctx *Context) error {
 		return errors.Annotatef(err, "failed to scp %s to %s:%s", c.srcPath, c.host, dstPath)
 	}
 
-	cmd := fmt.Sprintf(`tar -xzf %s -C %s && rm %s`, dstPath, dstDir, dstPath)
+	cmd := fmt.Sprintf(`tar --no-same-owner -zxf %s -C %s && rm %s`, dstPath, dstDir, dstPath)
 
 	_, stderr, err := exec.Execute(cmd, false)
 	if err != nil {