Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default version used by tiup should be the latest stable version #1119

Closed
zier-one opened this issue Feb 2, 2021 · 0 comments · Fixed by #1128
Closed

The default version used by tiup should be the latest stable version #1119

zier-one opened this issue Feb 2, 2021 · 0 comments · Fixed by #1128
Labels
type/feature-request Categorizes issue as related to a new feature.
Milestone
v1.3.3

Comments

@zier-one
Copy link
Contributor

zier-one commented Feb 2, 2021

Feature Request

Is your feature request related to a problem? Please describe:

The default version used by tiup should be the latest stable version, such as 5.0.0 or 4.0.9, but not 5.0.0-rc

tiup uses the 5.0.0-rc version of the toolchain by default for now:

➜  tiup cdc version
Starting component `cdc`: /home/leoppro/.tiup/components/cdc/v5.0.0-rc/cdc version
Release Version: v5.0.0-rc
Git Commit Hash: e0f35faf5def0f842e50dd9cd9485d33fc967ff3
Git Branch: heads/refs/tags/v5.0.0-rc
UTC Build Time: 2021-01-12 06:07:28
Go Version: go version go1.13 linux/amd64

But this is not reasonable, tiup should use the latest stable version as the default toolchain:

➜  tiup cdc version
Starting component `cdc`: /home/leoppro/.tiup/components/cdc/v4.0.9/cdc version
Release Version: v4.0.9
Git Commit Hash: 04e028419387871b80ddc95377751092f03f26ae
Git Branch: heads/refs/tags/v4.0.9
UTC Build Time: 2020-12-19 04:52:36
Go Version: go version go1.13 linux/amd64
@zier-one zier-one added the type/feature-request Categorizes issue as related to a new feature. label Feb 2, 2021
@lucklove lucklove added this to the v1.3.3 milestone Feb 2, 2021
lucklove added a commit to lucklove/tiup that referenced this issue Feb 4, 2021
@lucklove
Fix the issue that the default selected version may be a preprelease …
958b1a3 
…version

Close pingcap#1119

Partly fix pingcap#1082
@lucklove lucklove mentioned this issue Feb 4, 2021
Merged
lucklove added a commit to lucklove/tiup that referenced this issue Feb 22, 2021
@lucklove
Fix the issue that the default selected version may be a preprelease …
6bc6d29 
…version

Close pingcap#1119

Partly fix pingcap#1082
ti-chi-bot added a commit that referenced this issue Feb 22, 2021
@lucklove @ti-chi-bot
Fix the issue that the default selected version may be a preprelease …
4544229 
…version (#1128)

* Fix the issue that the default selected version may be a preprelease version

Close #1119

Partly fix #1082

* Add test

* Test

* Fix nightly

* Fix test

* Fix nightly clone

Close #1108

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
lucklove added a commit to lucklove/tiup that referenced this issue Mar 4, 2021
@lucklove @ti-chi-bot
Fix the issue that the default selected version may be a preprelease …
0acc43a 
…version (pingcap#1128)

* Fix the issue that the default selected version may be a preprelease version

Close pingcap#1119

Partly fix pingcap#1082

* Add test

* Test

* Fix nightly

* Fix test

* Fix nightly clone

Close pingcap#1108

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Milestone
v1.3.3
Development

Successfully merging a pull request may close this issue.

Fix the issue that the default selected version may be a preprelease version lucklove/tiup
2 participants
@lucklove @zier-one