Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.1.0: default alertmanager.yaml not deployed correctly #735

Closed
lucklove opened this issue Sep 1, 2020 · 1 comment
Closed

v1.1.0: default alertmanager.yaml not deployed correctly #735

lucklove opened this issue Sep 1, 2020 · 1 comment
Labels
priority/P1 Indicates that the priority of a issue is high. status/TODO Categorizes issue as we will do it. type/bug Categorizes issue as related to a bug.

Comments

@lucklove
Copy link
Member

lucklove commented Sep 1, 2020

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

tiup cluster deploy cluster with alertmanager (no local config)
tiup cluster start cluster

  1. What did you expect to see?
    the cluster start correctly

  2. What did you see instead?
    alertmanager not start, the config file is missing.

  3. What version of TiUP are you using (tiup --version)?
    v1.1.0

	if spec.ConfigFilePath != "" {
		dst = filepath.Join(paths.Deploy, "conf", "alertmanager.yml")
		return i.TransferLocalConfigFile(e, spec.ConfigFilePath, dst)
	}

	configPath := filepath.Join(paths.Cache, fmt.Sprintf("alertmanager_%s.yml", i.GetHost()))
	return config.NewAlertManagerConfig().ConfigToFile(configPath)

       // Forget transfer here
@lucklove lucklove added type/bug Categorizes issue as related to a bug. status/TODO Categorizes issue as we will do it. priority/P1 Indicates that the priority of a issue is high. labels Sep 1, 2020
lucklove added a commit to lucklove/tiup that referenced this issue Sep 1, 2020
@lucklove
Fix missing alertmanager.yml
a13ad71 
Fix pingcap#735

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove
Copy link
Member Author

lucklove commented Sep 1, 2020

Fixed by #738

@lucklove lucklove closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/P1 Indicates that the priority of a issue is high. status/TODO Categorizes issue as we will do it. type/bug Categorizes issue as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucklove