Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup doesn't handle the label setting when import from ansible inventory.ini #838

Closed
Win-Man opened this issue Oct 12, 2020 · 2 comments · Fixed by #766 or #843
Closed

tiup doesn't handle the label setting when import from ansible inventory.ini #838

Win-Man opened this issue Oct 12, 2020 · 2 comments · Fixed by #766 or #843
Assignees
@lucklove
Labels
type/bug Categorizes issue as related to a bug.
Milestone
v1.2.1

Comments

@Win-Man
Copy link
Contributor

Win-Man commented Oct 12, 2020 •
edited by lucklove
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

I imported inventrory.ini from ansible to tiup, but seems tiup didn't handle the lable setting in the inventory.ini. Therefor I got a warning message when executed tiup cluster display:
image

I configed label in the inventory.ini：
image

  1. What did you expect to see?
    tiup cluster display shows no warning.

  2. What did you see instead?

  3. What version of TiUP are you using (tiup --version)?
@Win-Man Win-Man added the type/bug Categorizes issue as related to a bug. label Oct 12, 2020
@lucklove lucklove added this to the v1.2.1 milestone Oct 12, 2020
@lucklove lucklove linked a pull request Oct 12, 2020 that will close this issue
Import configuration when migrating a cluster from Ansible #766
Merged
@lucklove
Copy link
Member

#766 may resolve this

@lucklove lucklove self-assigned this Oct 15, 2020
lucklove added a commit to lucklove/tiup that referenced this issue Oct 15, 2020
@lucklove
Introduce a more graceful way to check labels
26310d1 
Fix pingcap#838

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove mentioned this issue Oct 15, 2020
Merged
@ti-srebot
Copy link
Contributor

Please edit this comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: pingcap/tidb#20100

1. Root Cause Analysis (RCA)

2. Symptom

3. All Trigger Conditions

4. Workaround (optional)

5. Affected versions

6. Fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucklove lucklove

Labels
type/bug Categorizes issue as related to a bug.
Projects
None yet
Milestone
v1.2.1
3 participants
@lucklove @Win-Man @ti-srebot