Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/spec: workaround if store IDs are not monotonically assigned #1011

Merged
merged 2 commits into from
Dec 25, 2020
Merged

cluster/spec: workaround if store IDs are not monotonically assigned #1011

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26daa42
cluster/spec: report store state as up if any of the stores is not to…
AstroProfundis Dec 24, 2020
7090aae
Merge branch 'master' into fix-3303
lucklove Dec 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion pkg/cluster/spec/tikv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"time"

"github.com/pingcap/errors"
"github.com/pingcap/kvproto/pkg/metapb"
"github.com/pingcap/tiup/pkg/cluster/api"
"github.com/pingcap/tiup/pkg/cluster/executor"
"github.com/pingcap/tiup/pkg/cluster/template/scripts"
Expand Down Expand Up @@ -70,15 +71,31 @@ func checkStoreStatus(storeAddr string, tlsCfg *tls.Config, pdList ...string) st
return "Down"
}

// only get status of the latest store, it is the store with lagest ID number
// only get status of the latest store, it is the store with largest ID number
// older stores might be legacy ones that already offlined
var latestStore *pdserverapi.StoreInfo

for _, store := range stores.Stores {
if storeAddr == store.Store.Address {
if latestStore == nil {
latestStore = store
continue
}

// If the PD leader has been switched multiple times, the store IDs
// may be not monitonically assigned. To workaround this, we iterate
// over the whole store list to see if any of the store's state is
// not marked as "tombstone", then use that as the result.
// See: https://github.com/tikv/pd/issues/3303
//
// It's logically not necessary to find the store with largest ID
// number anymore in this process, but we're keeping the behavior
// as the reasonable approach would still be using the state from
// latest store, and this is only a workaround.
if store.Store.State != metapb.StoreState_Tombstone {
return store.Store.StateName
}

if store.Store.Id > latestStore.Store.Id {
latestStore = store
}
Expand Down