Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add role and node filter for check subcommand #1030

Merged
merged 3 commits into from
Jan 4, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Close #1022

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to update the documentation

Release notes:

cluster: support filtering node and role in `check` subcommand

@AstroProfundis AstroProfundis added type/new-feature Categorizes pr as related to a new feature. type/enhancement Categorizes issue or PR as related to an enhancement. category/usability Categorizes issue or PR as a usability enhancement. labels Dec 30, 2020
@AstroProfundis AstroProfundis self-assigned this Dec 30, 2020
@ti-chi-bot ti-chi-bot requested a review from july2993 December 30, 2020 08:50
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2020
@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #1030 (faaa390) into master (9a09991) will decrease coverage by 3.85%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
- Coverage   55.73%   51.87%   -3.86%     
==========================================
  Files         280      280              
  Lines       19750    19759       +9     
==========================================
- Hits        11007    10250     -757     
- Misses       7038     7889     +851     
+ Partials     1705     1620      -85     
Flag Coverage Δ
cluster 38.43% <8.33%> (-5.25%) ⬇️
dm 23.98% <ø> (-0.07%) ⬇️
integrate 46.13% <8.33%> (-3.89%) ⬇️
playground 20.31% <ø> (ø)
tiup 16.48% <ø> (ø)
unittest 22.27% <8.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/check.go 6.73% <8.33%> (-72.81%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
components/cluster/command/audit.go 27.27% <0.00%> (-54.55%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-53.07%) ⬇️
pkg/cluster/manager/patch.go 0.00% <0.00%> (-51.81%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/cluster/manager/cleanup.go 0.00% <0.00%> (-49.19%) ⬇️
pkg/cluster/operation/operation.go 34.78% <0.00%> (-43.48%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a09991...faaa390. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented Jan 4, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2021
@lucklove
Copy link
Member

lucklove commented Jan 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b45eb50

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot ti-chi-bot merged commit cbc4e18 into pingcap:master Jan 4, 2021
@AstroProfundis AstroProfundis deleted the partial-check branch January 5, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement. type/new-feature Categorizes pr as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support check specified node use -N
4 participants