tests/tiup-cluster: check prometheus monitored components #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
the
size/XS
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
+ Coverage 55.66% 55.75% +0.08%
==========================================
Files 280 280
Lines 19759 19759
==========================================
+ Hits 10999 11016 +17
+ Misses 7048 7035 -13
+ Partials 1712 1708 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AstroProfundis
approved these changes
Jan 5, 2021
|
The test failed, there is something wrong, @9547 could you take a look? |
I'll look at it tonight |
9547
force-pushed
the
fix/wrong-prometheus-grafana-name
branch
from
bdd1652 to
b7ecc45
Compare
9547
force-pushed
the
fix/wrong-prometheus-grafana-name
branch
from
b7ecc45 to
63c4c2b
Compare
ti-chi-bot
added
size/S
|
/lgtm |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 63c4c2b
|
ti-chi-bot
added
the
status/can-merge
lucklove
pushed a commit
that referenced
this pull request
Jan 28, 2021
* fix(cluster/spec): missing {alertmanager,grafana}s
* typo(tests/tiup-cluster): wrong use grep expr
* fix(tests/tiup-cluster): tiflash only available if no_tls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #1038
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: