*: remove v0manifest #1078
*: remove v0manifest #1078
Conversation
AstroProfundis
added
the
type/enhancement
ti-chi-bot
added
the
size/XXL
Codecov Report
@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
- Coverage 51.90% 48.97% -2.94%
==========================================
Files 282 278 -4
Lines 19936 19695 -241
==========================================
- Hits 10348 9645 -703
- Misses 7962 8524 +562
+ Partials 1626 1526 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkg/environment/env.go
Outdated
| @@ -368,28 +256,6 @@ func ParseCompVersion(spec string) (string, pkgver.Version) { | |||
|
|
|||
| // IsSupportedComponent return true if support if platform support the component. | |||
| func (env *Environment) IsSupportedComponent(component string) bool { | |||
There was a problem hiding this comment.
Should we delete this function?
| @@ -99,38 +96,19 @@ func InitEnv(options repository.Options) (*Environment, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| var repo *repository.Repository | |||
| var v1repo *repository.V1Repository | |||
There was a problem hiding this comment.
should we rename v1repo to repo? And likewise v1Repo and V1Repository
There was a problem hiding this comment.
I think it's OK, as we don't guarantee there won't be v2repo in the future. The only misleading thing might be that we still use v0.1.0 as spec_version in v1Manifest.
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: abc85da
|
ti-chi-bot
added
the
status/can-merge
|
@AstroProfundis: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
* remove v0manifest from repository & env * remove redudant code in repository * remove v0manifest from profile * remove v0manifest * remove more redudant code Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
What problem does this PR solve?
Close #906
What is changed and how it works?
Remove
v0manifestand legacy codes using it.Check List
Tests
Code changes
Side effects
Release notes: