Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dm destroy support --force --retaion-node-data --retaion-role-data #1080

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Feature/dm destroy support --force --retaion-node-data --retaion-role-data #1080

merged 2 commits into from
Jan 20, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jan 19, 2021

What problem does this PR solve?

implement #1079

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2021
@codecov-io
Copy link

codecov-io commented Jan 19, 2021 •
edited
Loading

Codecov Report

Merging #1080 (3658776) into master (e33e3ba) will decrease coverage by 26.05%.
The diff coverage is 53.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1080       +/-   ##
===========================================
- Coverage   55.97%   29.92%   -26.06%     
===========================================
  Files         282      268       -14     
  Lines       19928    18597     -1331     
===========================================
- Hits        11155     5565     -5590     
- Misses       7044    12179     +5135     
+ Partials     1729      853      -876
Flag Coverage Δ
cluster ?
dm ?
integrate 21.51% <ø> (-28.70%) ⬇️
playground 20.29% <ø> (ø)
tiup 16.44% <ø> (ø)
unittest 22.41% <53.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/command/destroy.go 43.75% <44.44%> (-31.25%) ⬇️
components/cluster/command/destroy.go 54.54% <66.66%> (-18.19%) ⬇️
pkg/meta/paths.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/utils.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/logger/log/log.go 0.00% <0.00%> (-100.00%) ⬇️
components/cluster/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/task/builder.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/bindversion.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33e3ba...3658776. Read the comment docs.

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 20, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3658776

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2021
@ti-chi-bot ti-chi-bot merged commit d9609b5 into pingcap:master Jan 20, 2021
@lucklove lucklove added the status/need-doc Indicates that we should update document before merge a PR. label Jan 20, 2021
mianhk pushed a commit to mianhk/tiup that referenced this pull request Jan 21, 2021
@jsvisa
Feature/dm destroy support --force --retaion-node-data --retaion-role…
b9f6773 
…-data (pingcap#1080)

* typo(cluster/command): destoyOpt -> destroyOpt

* feat(dm/command): destory --force --retain-node-data,--retain-role-data
@9547 9547 deleted the feature/dm-force branch April 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 Awaiting requested review from july2993

@lucklove lucklove Awaiting requested review from lucklove

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/need-doc Indicates that we should update document before merge a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@9547 @codecov-io @lucklove @ti-chi-bot @jsvisa