Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark required flag in help message #1089

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Conversation

lucklove
Copy link
Member

Fix #792

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2021
@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #1089 (5631cd0) into master (7b86020) will increase coverage by 35.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1089       +/-   ##
===========================================
+ Coverage   20.91%   56.57%   +35.65%     
===========================================
  Files          79      283      +204     
  Lines        6866    20007    +13141     
===========================================
+ Hits         1436    11318     +9882     
- Misses       5097     6934     +1837     
- Partials      333     1755     +1422     
Flag Coverage Δ
cluster 45.09% <100.00%> (?)
dm 24.81% <100.00%> (?)
integrate 51.03% <100.00%> (+30.11%) ⬆️
playground 20.91% <ø> (ø)
tiup 16.38% <ø> (?)
unittest 22.72% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/scale_in.go 90.47% <100.00%> (ø)
components/dm/command/import.go 19.04% <100.00%> (ø)
components/dm/command/scale_in.go 60.60% <100.00%> (ø)
components/cluster/command/rename.go 66.66% <0.00%> (ø)
components/cluster/command/prune.go 75.00% <0.00%> (ø)
pkg/cluster/spec/tiflash.go 73.69% <0.00%> (ø)
pkg/cliutil/tui.go 59.18% <0.00%> (ø)
pkg/cluster/template/scripts/pump.go 72.41% <0.00%> (ø)
components/dm/command/exec.go 85.71% <0.00%> (ø)
pkg/cluster/template/config/prometheus.go 71.42% <0.00%> (ø)
... and 246 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b86020...05c74e8. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3cc65cf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2021
@ti-chi-bot
Copy link
Member

@lucklove: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fe8a3b8 into pingcap:master Jan 25, 2021
lucklove added a commit that referenced this pull request Jan 28, 2021
Fix #792

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
mianhk pushed a commit to mianhk/tiup that referenced this pull request Jan 29, 2021
Fix pingcap#792

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster-version and ansible dir params in 'tiup dm import' are mandatory, please add them in command help info
4 participants